Fix loadModule for wasmJs #481
Merged
+28
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@alex28sh please rebase the branch onto |
…o be present there. It worked previously, but recent changes in K/Wasm (that'll land in 2.3.20) triggered the following error: > Cannot determine intended module format because both require() and top-level await are present. > If the code is intended to be CommonJS, wrap await in an async function. > If the code is intended to be an ES module, replace require() with import. This change provides a workaround for the issue. [1] https://kotlinlang.org/docs/wasm-js-interop.html#kotlin-wasm-and-kotlin-js-interoperability-differences
alex28sh
force-pushed
the
fix-loadModule-wasmJs
branch
from
7d0b39a to
6c89126
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o be present there.
It worked previously, but recent changes in K/Wasm (that'll land in 2.3.20) triggered the following error:
This change provides a workaround for the issue.
[1] https://kotlinlang.org/docs/wasm-js-interop.html#kotlin-wasm-and-kotlin-js-interoperability-differences